Skip to content

[CALCITE-7471] Alias is not auto generated for MATCH_RECOGNIZE #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snuyanzin merged 1 commit into from
Apr 13, 2026
+26 −1
Merged

[CALCITE-7471] Alias is not auto generated for MATCH_RECOGNIZE #4882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2640,7 +2640,7 @@ private SqlNode registerFrom(
case MATCH_RECOGNIZE:
registerMatchRecognize(parentScope, usingScope,
(SqlMatchRecognize) node, enclosingNode, alias, forceNullable);
return node;
return newNode;
Copy link
Copy Markdown
Contributor Author

@snuyanzin snuyanzin Apr 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is initialized at

calcite/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java

Lines 2539 to 2540 in 37448dc

// Add an alias if necessary.
SqlNode newNode = node;

and

calcite/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java

Lines 2568 to 2574 in 37448dc

alias = SqlValidatorUtil.alias(node, nextGeneratedId++);
if (config.identifierExpansion()) {
// Since we're expanding identifiers, we should make the
// aliases explicit too, otherwise the expanded query
// will not be consistent if we convert back to SQL, e.g.
// "select EXPR$1.EXPR$2 from values (1)".
newNode = SqlValidatorUtil.addAlias(node, alias);

so need to reuse it

Copy link
Copy Markdown
Member

@caicancai caicancai Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your detailed explanation.


case PIVOT:
registerPivot(parentScope, usingScope, (SqlPivot) node, enclosingNode,
Expand Down
25 changes: 25 additions & 0 deletions core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2575,6 +2575,31 @@ void testLikeAndSimilarFails() {
.rewritesTo(expected5);
sql(expected5)
.withParserConfig(c -> c.withQuoting(Quoting.BACK_TICK)).ok();

// Test cases for [CALCITE-7471] https://issues.apache.org/jira/browse/CALCITE-7471
// Alias is not auto generated for `MATCH_RECOGNIZE`
final String sql6 = "SELECT *\n"
+ "FROM emp\n"
+ "MATCH_RECOGNIZE (\n"
+ " MEASURES\n"
+ " FINAL COUNT(A.deptno) AS deptno\n"
+ " PATTERN (A B)\n"
+ " DEFINE\n"
+ " A AS A.empno = 123\n"
+ ")";

final String expected6 = "SELECT `EXPR$0`.`DEPTNO`\n"
+ "FROM `CATALOG`.`SALES`.`EMP` AS `EMP` MATCH_RECOGNIZE(\n"
+ "MEASURES FINAL COUNT(`A`.`DEPTNO`) AS `DEPTNO`\n"
+ "PATTERN (`A` `B`)\n"
+ "DEFINE `A` AS PREV(`A`.`EMPNO`, 0) = 123) AS `EXPR$0`";

sql(sql6)
.withValidatorConfig(c -> c.withIdentifierExpansion(true))
.rewritesTo(expected6);

sql(expected6)
.withParserConfig(c -> c.withQuoting(Quoting.BACK_TICK)).ok();
}

@Test void testIntervalTimeUnitEnumeration() {
Expand Down
Loading