[CALCITE-7464] Refactor type coercion in array/map functions to avoid mutating operands as side effects#4869
[CALCITE-7464] Refactor type coercion in array/map functions to avoid mutating operands as side effects#4869caicancai wants to merge 1 commit intoapache:mainfrom
Conversation
caicancai
force-pushed
the
7464
branch
2 times, most recently
from
bc1634b to
d6e97f7
Compare
… mutating operands as side effects
caicancai
force-pushed
the
7464
branch
2 times, most recently
from
b6e8227 to
aa37529
Compare
|
|
@mihaibudiu If you have time, could you please help follow up on this PR? You should be very clear about the context. |
| opBinding.getTypeFactory(), opBinding.collectOperandTypes()); | ||
|
|
||
| // explicit cast elements to component type if they are not same | ||
| SqlValidatorUtil.adjustTypeForMapConstructor(type, opBinding); |
There was a problem hiding this comment.
Is there a reason SqlValidatorUtil.adjustTypeForArrayConstructor is not considered in this PR?
| if (callBinding.isTypeCoercionEnabled()) { | ||
| callBinding.getValidator().getTypeCoercion() | ||
| .collectionFunctionCoercion(callBinding); | ||
| } |
There was a problem hiding this comment.
might be a breaking change for downstream projects who do not use typeCoercion
imho need at least put info about this in release notes
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
Can we discuss the design first in Jira?
| List<RelDataType> operandTypes, | ||
| List<SqlTypeFamily> expectedFamilies); | ||
|
|
||
| /** |
There was a problem hiding this comment.
Type coercion can depend on functions, it's the other way around: functions can use some services from type coercion.
So I don't understand what this function means.
| @Override public boolean collectionFunctionCoercion(SqlCallBinding binding) { | ||
| final SqlCall call = binding.getCall(); | ||
| switch (call.getKind()) { | ||
| case MAP_VALUE_CONSTRUCTOR: |
There was a problem hiding this comment.
Type coercion cannot depend on various functions like ARRAY_APPEND.
caicancai
added
the
discussion-in-jira
3 participants
https://issues.apache.org/jira/browse/CALCITE-7464