Skip to content

GH-49563: [C++][CMake] Remove clang/infer tools detection #49575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Mar 25, 2026
Merged

GH-49563: [C++][CMake] Remove clang/infer tools detection #49575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae01da
Export `CLANG_TOOLS_PATH` to `llvm@18`
alinaliBQ Mar 20, 2026
4721b98
Try kou's suggestion
alinaliBQ Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,17 +211,6 @@ else()
set(MSVC_TOOLCHAIN FALSE)
endif()

find_package(ClangTools)
find_package(InferTools)
if("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1"
OR CLANG_TIDY_FOUND
OR INFER_FOUND)
# Generate a Clang compile_commands.json "compilation database" file for use
# with various development tools, such as Vim's YouCompleteMe plugin.
# See http://clang.llvm.org/docs/JSONCompilationDatabase.html
set(CMAKE_EXPORT_COMPILE_COMMANDS 1)
endif()

# Needed for Gandiva.
# Use the first Python installation on PATH, not the newest one
set(Python3_FIND_STRATEGY "LOCATION")
Expand Down Expand Up @@ -649,22 +638,6 @@ if(UNIX)
VERBATIM)
endif(UNIX)

#
# "make infer" target
#

if(${INFER_FOUND})
# runs infer capture
add_custom_target(infer ${BUILD_SUPPORT_DIR}/run-infer.sh ${INFER_BIN}
${CMAKE_BINARY_DIR}/compile_commands.json 1)
# runs infer analyze
add_custom_target(infer-analyze ${BUILD_SUPPORT_DIR}/run-infer.sh ${INFER_BIN}
${CMAKE_BINARY_DIR}/compile_commands.json 2)
# runs infer report
add_custom_target(infer-report ${BUILD_SUPPORT_DIR}/run-infer.sh ${INFER_BIN}
${CMAKE_BINARY_DIR}/compile_commands.json 3)
endif()

#
# Link targets
#
Expand Down
122 changes: 0 additions & 122 deletions cpp/cmake_modules/FindClangTools.cmake
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions cpp/cmake_modules/FindInferTools.cmake
View file
Open in desktop

This file was deleted.

Loading