fix(streaming): add helpful error for malformed tool JSON in non-beta path#1331
Open
qozle wants to merge 1 commit intoanthropics:mainfrom
Open
fix(streaming): add helpful error for malformed tool JSON in non-beta path#1331qozle wants to merge 1 commit intoanthropics:mainfrom
qozle wants to merge 1 commit intoanthropics:mainfrom
Conversation
…non-beta path The beta streaming path already wraps the from_json call with a try-except that produces an actionable error message. The non-beta path was missing the same guard, causing a raw jiter ValueError with no context when the model emits malformed JSON during tool input streaming. Fixes anthropics#1265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1265.
What changed
src/anthropic/lib/streaming/_messages.pyhad a barefrom_json()call with no error handling on theinput_json_deltapath. When the model emits malformed JSON during a streaming tool call, users got a rawjiterValueErrorwith no context:The beta path (
_beta_messages.py) already wraps the identical call with atry-exceptthat produces an actionable message. This PR adds the same guard to the non-beta path so both paths behave consistently.After this fix
Diff
6-line change, no behavior change for valid JSON. The error message text is identical to the existing beta path.