feat(opencode): add pre-execution shell command safety validator#27070
Open
jinguanghai wants to merge 1 commit into
Open
feat(opencode): add pre-execution shell command safety validator#27070jinguanghai wants to merge 1 commit into
jinguanghai wants to merge 1 commit into
Conversation
Adds an optional safetyCheck() function that validates shell commands against 14 known dangerous patterns before execution. - 5 BLOCK-level patterns (reject immediately) - 7 WARN patterns (allow with warning) - 2 LOG patterns (record for review) Tests: 10 test cases covering all 14 patterns. No breaking changes. No new dependencies. Closes anomalyco#27069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional safetyCheck() function that validates shell commands against 14 known dangerous patterns before execution.
Issue for this PR
Closes #27069
Type of change
What does this PR do?
Adds
tool/safety.ts— a pre-execution shell command safety validator with 14 danger patterns (5 BLOCK, 7 WARN, 2 LOG). The function is self-contained with no integration into the execute flow yet, making this PR minimal and non-breaking.How did you verify your code works?
Added 10 test cases covering all 14 patterns (BLOCK/WARN/LOG/SAFE). Tests pass locally:
bun test test/tool/safety.test.tsChecklist