feat(app): enhance error handling by unwrapping SDK-wrapped errors in formatServerError#27061
Draft
OpeOginni wants to merge 1 commit into
Draft
feat(app): enhance error handling by unwrapping SDK-wrapped errors in formatServerError#27061OpeOginni wants to merge 1 commit into
OpeOginni wants to merge 1 commit into
Conversation
… formatServerError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27060
Type of change
What does this PR do?
This PR properly unwraps the errors passed from the server to be able to get the cause and pass it to the user in the toast.
How did you verify your code works?
Tested with an invalid config and the toast was giving proper data on the issue. Also added a regression test to make sure that the body is always unwrapped from the error.
Screenshots / recordings
Checklist