fix(app): desktop app & Safari comments via button click#17520
Open
goszczynskip wants to merge 1 commit intoanomalyco:devfrom
Open
fix(app): desktop app & Safari comments via button click#17520goszczynskip wants to merge 1 commit intoanomalyco:devfrom
goszczynskip wants to merge 1 commit intoanomalyco:devfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #11947
Type of change
What does this PR do?
This PR fixes the bug in desktop app and in Safari where adding comments to file view via button mouse click was impossible in OSX.
Issue was present because of Safari different handling of the shadow dom events propagation compared to other browsers.
Chain of (important) actions happening on submit button click in Safari:
How did you verify your code works?
I've run local version of Opencode desktop Tauri app in OSX. Verified that it's broken before fixes.
Also I've verified that the same happens in web view in Safari.
I've run following manual tests in lastest Chrome, Firefox and Safari:
I've tested that comments are added on button clicks.
I've tested that line comment popover isn't closed on clicks within popover.
I've tested that clicking on other lines closes line comment popover.
Screenshots / recordings
Screen.Recording.2026-03-14.at.20.53.07.mov
Checklist