fix(project): use case-insensitive path comparison for global session migration on Windows#17514
Open
NamedIdentity wants to merge 1 commit intoanomalyco:devfrom
Open
fix(project): use case-insensitive path comparison for global session migration on Windows#17514NamedIdentity wants to merge 1 commit intoanomalyco:devfrom
NamedIdentity wants to merge 1 commit intoanomalyco:devfrom
Conversation
… migration on Windows On Windows, directory paths are case-insensitive but migrateFromGlobal compared stored session directories against the current worktree using strict equality. When a parent directory was renamed with different casing (e.g. dtd -> DTD), sessions created under the old casing were never migrated to the correct project. Use SQL LOWER() on Windows to match directories case-insensitively, and path.normalize() to handle mixed slash directions. Preserves exact comparison on case-sensitive platforms. Relates to anomalyco#17183
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17518
Type of change
What does this PR do?
The global session migration (inlined in #16814) uses
eq(SessionTable.directory, data.worktree)— SQLite strict equality. On Windows, paths are case-insensitive but this comparison is case-sensitive, so sessions stored underC:\ai-work\dtd\projectnever matchC:\ai-work\DTD\projectafter a parent directory rename.Fix: on Windows, use
LOWER()in the SQL comparison andpath.normalize()to handle mixed slash directions. Non-Windows platforms keep the exact comparison since their filesystems are case-sensitive.How did you verify your code works?
globalafter a parent directory was renamed fromdtdtoDTDLOWER()matching — all sessions correctly reassignedScreenshots / recordings
N/A — not a UI change.
Checklist