fix(cdk/drag-drop): Support for nested drop containers#32525
Open
aparzi wants to merge 1 commit intoangular:mainfrom
Open
fix(cdk/drag-drop): Support for nested drop containers#32525aparzi wants to merge 1 commit intoangular:mainfrom
aparzi wants to merge 1 commit intoangular:mainfrom
Conversation
aparzi
force-pushed
the
fix-issue-16671
branch
from
f122cc5 to
7c4c212
Compare
adolgachev
added
the
action: review
aparzi
force-pushed
the
fix-issue-16671
branch
from
7c4c212 to
3a8fb56
Compare
Fixes a two issues: - The first fixed issue is that the elements of cdkDropListConnectedTo previously had to be ordered correctly to support moving items into an inner drop container. Sepcifically, inner drop containers had to be listed before their outer ancestors. - The second fixed issue is that items of an inner container could not be re-ordered without moving the item out of the container and then back in. Fixes angular#16671
Contributor
|
Looks like theres some timeout issues happening in the drag-and-drop tests |
Author
@andrewseguin @adolgachev |
Member
|
If both brother fail, it likely a legit failure. You should be able to reproduce it localy by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a two issues:
The first fixed issue is that the elements of cdkDropListConnectedTo previously had to be ordered correctly to support moving items into an inner drop container. Sepcifically, inner drop containers had to be listed before their outer ancestors.
The second fixed issue is that items of an inner container could not be re-ordered without moving the item out of the container and then back in.
Fixes #16671