Skip to content

Replace deprecated Divider with HorizontalDivider in Jetchat#1664

Open
amEya911 wants to merge 2 commits intoandroid:mainfrom
amEya911:fix/replace-deprecated-divider-jetchat
Open

Replace deprecated Divider with HorizontalDivider in Jetchat#1664
amEya911 wants to merge 2 commits intoandroid:mainfrom
amEya911:fix/replace-deprecated-divider-jetchat

Conversation

@amEya911
Copy link

@amEya911 amEya911 commented Mar 7, 2026

What I have done and why

  • Replaced deprecated Divider with HorizontalDivider in Jetchat's Profile.kt and Conversation.kt

androidx.compose.material3.Divider has been deprecated since Material3 1.2.0 in favor of HorizontalDivider. As an official Google sample, using deprecated APIs leads to developers copying outdated patterns into their own projects.

Fixes #1663

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Jetchat sample application by migrating from the deprecated Divider composable to the recommended HorizontalDivider. This change ensures that the sample adheres to current Material3 guidelines, preventing the propagation of outdated API usage in projects that might reference Jetchat as an example.

Highlights

  • Deprecated API Replacement: Replaced the deprecated androidx.compose.material3.Divider with androidx.compose.material3.HorizontalDivider in Profile.kt and Conversation.kt to align with Material3 1.2.0 recommendations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/Conversation.kt
    • Updated import from androidx.compose.material3.Divider to androidx.compose.material3.HorizontalDivider.
    • Replaced Divider with HorizontalDivider in the DayHeaderLine composable.
  • Jetchat/app/src/main/java/com/example/compose/jetchat/profile/Profile.kt
    • Updated import from androidx.compose.material3.Divider to androidx.compose.material3.HorizontalDivider.
    • Replaced Divider with HorizontalDivider in the ProfileProperty composable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the deprecated Divider composable with HorizontalDivider in Conversation.kt and Profile.kt. The changes are correct and address the deprecation as intended.

@riggaroo riggaroo enabled auto-merge March 10, 2026 12:11
auto-merge was automatically disabled March 10, 2026 12:27

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Jetchat uses deprecated Divider instead of HorizontalDivider

2 participants