feat(popup): add animation_duration config for popup/card widgets#744
Closed
Louis047 wants to merge 2 commits intoamnweb:mainfrom
Closed
feat(popup): add animation_duration config for popup/card widgets#744Louis047 wants to merge 2 commits intoamnweb:mainfrom
Louis047 wants to merge 2 commits intoamnweb:mainfrom
Conversation
Contributor
Author
|
If this gets approval and required improvements, do let me know so I can go ahead and implement it as well, including to add details about |
Louis047
force-pushed
the
feat/popup-animation-duration-clean
branch
4 times, most recently
from
6299487 to
bfbe82e
Compare
Louis047
force-pushed
the
feat/popup-animation-duration-clean
branch
3 times, most recently
from
63e66fe to
6299487
Compare
Louis047
force-pushed
the
feat/popup-animation-duration-clean
branch
from
6299487 to
783d4f9
Compare
Louis047
force-pushed
the
feat/popup-animation-duration-clean
branch
2 times, most recently
from
6299487 to
783d4f9
Compare
- Add animation_duration parameter to PopupWidget class (default: 80ms) - Add animation_duration config to 24 widget popup/menu configs - Update 26 PopupWidget instantiations to use custom animation duration - Covers all widgets with popup/card support This allows users to customize the fade animation duration for popup menus and cards, similar to the existing power_menu animation_duration option. Resolves: amnweb#742
Louis047
force-pushed
the
feat/popup-animation-duration-clean
branch
from
783d4f9 to
4618434
Compare
Contributor
Author
|
Superseded by #781 to provide the same changes on a clean branch with a clean review timeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
animation_durationparameter toPopupWidgetclass (default: 80ms)animation_durationconfig to 24 widget popup/menu validation configsDescription
This PR implements the feature requested in issue #742 - allowing users to customize the fade animation duration for popup menus and cards across all widgets that support them.
Changes
animation_durationparameter (default: 80ms) to control fade in/out animation durationanimation_duration: int = 80to 24 popup/menu configsWidgets Updated
clock, weather, open_meteo, volume, brightness, media, todo, notes, microphone, power_menu, disk, language, home, traffic, copilot, server_monitor, pomodoro, vscode, github, libre_monitor, power_plan, quick_launch, komorebi/control, komorebi/active_layout, systray/popup
Usage Example
Related Issue
Implements #742