Skip to content

Set CMP0177 policy to NEW#291

Closed
ClausKlein wants to merge 1 commit intoaminya:mainfrom
ClausKlein:feature/set-cmp0135
Closed

Set CMP0177 policy to NEW#291
ClausKlein wants to merge 1 commit intoaminya:mainfrom
ClausKlein:feature/set-cmp0135

Conversation

@ClausKlein
Copy link
Contributor

@ClausKlein ClausKlein commented Apr 27, 2025 •
edited
Loading

this fix #290

@ClausKlein ClausKlein force-pushed the feature/set-cmp0135 branch from e7ade41 to f20c24f Compare April 27, 2025 18:03
@ClausKlein ClausKlein changed the title Set CMP0135 policy to NEW Set CMP0177 policy to NEW Apr 27, 2025
aminya
aminya approved these changes Feb 23, 2026
View reviewed changes
src/Index.cmake
include_guard()

if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.31.0")
cmake_policy(SET CMP0177 NEW)
Copy link
Owner

@aminya aminya Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a short comment about what this policy does?

https://cmake.org/cmake/help/latest/policy/CMP0177.html

@ClausKlein ClausKlein closed this by deleting the head repository Feb 23, 2026
@aminya
Copy link
Owner

aminya commented Feb 23, 2026

@ClausKlein Any reason to close this? I'm still interested in merging this. Sorry for the review delay.

@aminya aminya added the enhancement New feature or request label Feb 23, 2026
@ClausKlein
Copy link
Contributor Author

ClausKlein commented Feb 23, 2026

@ClausKlein Any reason to close this? I'm still interested in merging this. Sorry for the review delay.

yes, I give it up to work with this project.

#292

@aminya
Copy link
Owner

aminya commented Feb 23, 2026

@ClausKlein I can take over these issues and merge the fixes.

@ClausKlein
Copy link
Contributor Author

ClausKlein commented Feb 23, 2026

@ClausKlein I can take over these issues and merge the fixes.

That does not really help without FILE_SET; cmake v4.3-rc1 is out.

"Wer zurück bleibt, den bestraft das Leben" Gorbatschow

@aminya
Copy link
Owner

aminya commented Feb 24, 2026

We can implement anything needed to support that.

He journeys not who rushes forth, then halts in weary need;
The true wayfarer treads the path with slow and steady speed.
Saadi

@aminya aminya mentioned this pull request Feb 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aminya aminya aminya approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New CMake 3.31 warning for policy CMP0177

2 participants

@ClausKlein @aminya