Open
Conversation
This was referenced Feb 6, 2026
|
@Flamefire this PR will need to be rebased, since the dev branch was force pushed. |
`-pie` builds an executable and when passed after `-shared` won't create a shared library anymore. CMake 4.1.0 changed the order of `CMAKE_SHARED_LINKER_FLAGS` to be passed after the shared-library-creation-flags and the build now fails. However it was wrong to pass this flag to the shared library linking anyway, so remove it from there.
Author
|
Thanks, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-piebuilds an executable and when passed after-sharedwon't create a shared library anymore.CMake 4.1.0 changed the order of
CMAKE_SHARED_LINKER_FLAGSto be passed after the shared-library-creation-flags and the build now fails.However it was wrong to pass this flag to the shared library linking anyway, so remove it from there.
What type of PR is this? (check all applicable)
Synopsis
Fixes d5c7c1b