Open
Conversation
… e2e tests and secure-container guide docs
fengcone
requested review from
Generalwin,
Pangjiping,
Spground,
hittyt,
jwx0925,
kevinlynx and
ninan-nn
as code owners
Collaborator
Author
|
see issue #174 |
hittyt
reviewed
Feb 26, 2026
Collaborator
There was a problem hiding this comment.
Binary files cannot be properly diffed or reviewed, may be remove binaries and add download script in Makefile is a better choice
| // runKubectl executes a kubectl command from the project root directory | ||
| func runKubectl(args ...string) (string, error) { | ||
| cmd := exec.Command("kubectl", args...) | ||
| cmd.Dir = "../../.." // 从 test/e2e_runtime/gvisor 回到项目根目录 |
Collaborator
There was a problem hiding this comment.
Keep the english comment style.
Navigate from test/e2e_runtime/gvisor to project root
| makeArgs = append(makeArgs, fmt.Sprintf("DOCKER_BUILD_ARGS=%s", dockerBuildArgs)) | ||
| } | ||
| cmd := exec.Command("make", makeArgs...) | ||
| cmd.Dir = "../../.." // 从 test/e2e_runtime/gvisor 回到项目根目录 |
Collaborator
There was a problem hiding this comment.
Comment is in Chinese issue.
Collaborator
There was a problem hiding this comment.
Unused Template File?
And same issue about /pool-runtimeclass.yaml?
|
|
||
| // RenderTemplate renders a YAML template file with given data | ||
| // templateFile is relative to e2e_runtime/ directory (e.g. "gvisor/testdata/pool.yaml") | ||
| func RenderTemplate(templateFile string, data map[string]interface{}) (string, error) { |
Collaborator
There was a problem hiding this comment.
RenderTemplate function is defined but never used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist