update yeoman-environment to v4#926
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 PR Reviewer
The diff upgrades yeoman-environment from v3 to v4 (ESM-only) by wrapping the dynamic import in a thin CJS shim. The approach is sound and the tests are updated consistently. One minor issue: the copyright year in the new file header is '2026' (a future year), and there is a missing error handling consideration for the dynamic import failure case, but neither is a blocking problem.
✅ LGTM! This PR looks good to merge.
💡 How to re-trigger
Comment /review or /pr-reviewer on this PR
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pru55e11
approved these changes
May 20, 2026
Contributor
pru55e11
left a comment
pru55e11
left a comment
There was a problem hiding this comment.
Tested locally, no issues. Ship it!
Contributor
Author
|
Will release once other lib updates to this repo are complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the yeoman-environment module to v4.
Related Issue
https://jira.corp.adobe.com/browse/ACNA-4609
Motivation and Context
Reduce deprecation warnings when updating aio-cli.
How Has This Been Tested?
aio app createScreenshots (if appropriate):
Types of changes
Checklist: