Merged
Conversation
- Updated the CompanyNotice struct to include StartTime and EndTime fields for better notice management. - Modified conversion functions to handle the new fields when converting between biz and model representations.
…date retrieval logic - Added CreateUserUID field to the CompanyNotice struct for tracking the creator of the notice. - Updated conversion functions to include CreateUserUID when converting between biz and model representations. - Enhanced GetCompanyNotice method to retrieve and display the creator's name based on CreateUserUID.
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
iwanghc
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/756
描述你的变更
补充缺失的模型定义
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
增加公告开始与结束时间
添加公告创建人UID字段
更新转换函数处理新增字段
调整服务层获取用户名称
Diagram Walkthrough
File Walkthrough
company_notice.go
服务层添加创建人名称逻辑internal/dms/service/company_notice.go
convert.go
更新转换函数支持新增字段internal/dms/storage/convert.go
model.go
扩展模型定义添加新字段internal/dms/storage/model/model.go