improve(Dataworker): Speed up BundleDataClient.loadDataFromScratch#1587
Merged
nicholaspai merged 6 commits intomasterfrom Jun 4, 2024
Merged
improve(Dataworker): Speed up BundleDataClient.loadDataFromScratch#1587nicholaspai merged 6 commits intomasterfrom
nicholaspai merged 6 commits intomasterfrom
Conversation
The slowdown in the executor/disputer is coming from slowdown in the bundleDataClient.loadData but we can short circuit this in the executor safely by loading from arweave
- Replacing `utils.getRelayHashFromEvent` implementation takes current bundle construction with ~5000 deposits and fills runtime from 80s to 5s - Fetching bundle data from arweave instead of from scratch in the executor saves executor time - Added timers for loading bundle data to help track regressions
nicholaspai
changed the title
nicholaspai
requested review from
james-a-morris,
mrice32 and
pxrl
as code owners
pxrl
approved these changes
Jun 4, 2024
Collaborator
pxrl
left a comment
pxrl
left a comment
There was a problem hiding this comment.
Given the speedup it makes sense to get this in ASAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Loading bundle data is now consistently taking 3-5 minutes given increased volume, likely stemming from increase in total bridge events per bundle
I've narrowed down, using timers, the slowdown to the
loadDataFromScratchand theSpokePoolClient.update()calls which together account for most of the vast majority of the total run time for any dataworker functionImplementation
utils.getRelayHashFromEventimplementation takes current bundle construction with ~5000 deposits and fills runtime from 160s to 5s within theloadDataFromScratchfunction.