Open
Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
grasphoper
reviewed
Apr 8, 2026
Comment on lines
+226
to
+232
| } else if (contractName === "DonationBox") { | ||
| // Suffix DonationBox with _OFT or _CCTP based on the deploying script. | ||
| if (broadcastFile.scriptName.includes("DstHandler")) { | ||
| contractName = "DonationBox_OFT"; | ||
| } else if (broadcastFile.scriptName.includes("SponsoredCCTP")) { | ||
| contractName = "DonationBox_CCTP"; | ||
| } |
Collaborator
There was a problem hiding this comment.
if (broadcastFile.scriptName.includes("DstHandler")) {
Seems like we could add another ..DstHanlder.. in the future by accident. Should we include full names here. Or almost full?
grasphoper
approved these changes
Apr 8, 2026
Collaborator
grasphoper
left a comment
grasphoper
left a comment
There was a problem hiding this comment.
Looks good, left one nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.