Conversation
…isal/bob-and-ink-sepolia
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70d53a476b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| nativeToken: "ETH", | ||
| publicRPC: "https://rpc-gel-sepolia.inkonchain.com", | ||
| blockExplorer: "https://explorer-sepolia.inkonchain.com", | ||
| cctpDomain: 21, |
There was a problem hiding this comment.
cctpDomain: 21 marks Ink Sepolia as CCTP-enabled, but TOKEN_SYMBOLS_MAP.USDC.addresses has no CHAIN_IDs.INK_SEPOLIA entry in src/tokens.ts (USDC section), unlike every other non-CCTP_NO_DOMAIN network. In consumers that treat cctpDomain != -1 as “USDC via CCTP is available,” this can produce undefined token-address lookups and failed routing/bridging flows for Ink Sepolia. Either add the Ink Sepolia USDC address or set this field to CCTP_NO_DOMAIN until USDC support is present.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e155cd34c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| blockExplorer: "https://explorer.gobob.xyz", | ||
| cctpDomain: CCTP_NO_DOMAIN, | ||
| oftEid: OFT_NO_EID, | ||
| hypDomainId: HYPERLANE_NO_DOMAIN_ID, |
There was a problem hiding this comment.
This entry marks BOB as having no Hyperlane domain (-1), but Hyperlane’s published domain list includes BOB with domain 60808 (matching its chain ID). Any downstream code that gates Hyperlane features on hypDomainId !== -1 will incorrectly disable BOB routing/messaging even though the chain is supported, so BOB-specific Hyperlane flows introduced by this network addition will never activate.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Codex Review: Didn't find any major issues. Hooray!
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fusmanii
requested review from
bmzig,
dijanin-brat,
grasphoper,
pxrl and
tbwebb22
1 participant
No description provided.