Skip to content

Minedetector - Improvement: Add setting to boost radius of detectors#11346

Merged
PabstMirror merged 22 commits intoacemod:masterfrom
OverlordZorn:mine-detector-custom-range
Apr 17, 2026
Merged

Minedetector - Improvement: Add setting to boost radius of detectors#11346
PabstMirror merged 22 commits intoacemod:masterfrom
OverlordZorn:mine-detector-custom-range

Conversation

@OverlordZorn
Copy link
Copy Markdown
Contributor

@OverlordZorn OverlordZorn commented Apr 7, 2026

When merged this pull request will:

  • add CBA Settings: Boost Radius
  • New Function: getDetectorRadius - returns radius based on settings
  • New Function: updateDetectorRadius - updates radius inside cached hashmap upon setting change
  • PostInit: Added CBA Eventhandler to call updateDetectorRadius

Motivation:

In some missions combined with some Mods, like IEDD Notebook, IEDs can be hard to spot.

Besides the ACE Mine Detectors with their rather short radius of 2.5 meters and the Vanilla Minedetector with its 15 meters + Radar screen, there is no inbetween.

This enables mission makers to finetune the players experience and provides something in the middle ground.

@johnb432
Copy link
Copy Markdown
Contributor

johnb432 commented Apr 7, 2026

Imo the settings contradict #11347 somewhat: you have a setting that forces everything to be the same, but in mentioned PR you make them different?
I don't see a point in the settings.

@OverlordZorn
Copy link
Copy Markdown
Contributor Author

Imo the settings contradict #11347 somewhat: you have a setting that forces everything to be the same, but in mentioned PR you make them different? I don't see a point in the settings.

Reasoning:

I've ran campaigns/missions with some IED mods like IEDD Notebook where the ace mine detectors where not practical cause the IEDs were that well hidden.

The only alternative i had was to give the players the vanilla mine detector. With some hacky commands i was able to at least disable the sidepanel overlay.

That is why i propose the setting.

If you're unhappy with the way the values are applied, then yea, its kinda awkward. I was considering a "modifier" setting/slider instead but that didnt felt right ether.

As an alternative, I can offer to make it an "boost" which adds range to the existing config radius.

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Apr 7, 2026

I think a single setting that applies a coefficient would be fine.

@OverlordZorn OverlordZorn marked this pull request as draft April 7, 2026 19:24
@OverlordZorn
Copy link
Copy Markdown
Contributor Author

I think a single setting that applies a coefficient would be fine.

im currently changing it to a "add boost" setting, can also condense it down to a single setting.

Im a bit hessitant to make it a coefficient due to it being an abritary number in "percentage".
by adding a boost people can add a "range" in meters, which i think is easier to grasp. but im open for other opinions here.

@OverlordZorn OverlordZorn changed the title Minedetector - Improvement: Add setting to control radius of detectors Minedetector - Improvement: Add setting to boost radius of detectors Apr 7, 2026
@OverlordZorn OverlordZorn marked this pull request as ready for review April 7, 2026 20:03
@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Apr 7, 2026

X + Y and X * Y are equally arbitrary.
I'd prefer the multiplier because then you know all detectors have been scaled by the same relative amount.

With a 2x multiplier a 2.5m detector has become 5m and a 5m detector has become 10m. The better detector is still has twice the radius of the worse detector.

With an addative boost of +2.5m the 2.5m detector has still become 5m, but the 5m detector is now only 7.5m, so instead of having double the radius it only has a 50% larger radius over the worse detector.

Comment thread addons/minedetector/functions/fnc_updateDetectorRadius.sqf Outdated
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Apr 8, 2026
@PabstMirror PabstMirror added this to the 3.21.1 milestone Apr 8, 2026
Comment thread addons/minedetector/stringtable.xml
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@OverlordZorn
Copy link
Copy Markdown
Contributor Author

hemtt run timed out

HTTPError: Response code 403 (rate limit exceeded)
    at Request.<anonymous> (D:\a\_actions\arma-actions\hemtt\v1\dist\main\index.js:6913:42)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'ERR_NON_2XX_3XX_RESPONSE',

@PabstMirror PabstMirror merged commit ccdab6f into acemod:master Apr 17, 2026
3 of 4 checks passed
[
QGVAR(BoostRadius), "SLIDER",
[LSTRING(BoostRadius), LSTRING(BoostRadius_Desc)],
format ["ACE %1", localize LSTRING(Category)],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering now if we need a whole new category for this one setting
we could do something like
[format ["ACE %1", LELSTRING(explosives,Menu)], localize LSTRING(Category)],
and put it under [ace explosives, mine detector]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, im just not a fan of having to search for a setting in an indirectly related category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants