Skip to content

Adding rule for epl-2.0 OR lgpl-2.1#4750

Open
CsatariGergely wants to merge 1 commit intoaboutcode-org:developfrom
nokia:rule-epl-2.0-OR-lgpl-2.1
Open

Adding rule for epl-2.0 OR lgpl-2.1#4750
CsatariGergely wants to merge 1 commit intoaboutcode-org:developfrom
nokia:rule-epl-2.0-OR-lgpl-2.1

Conversation

@CsatariGergely
Copy link
Copy Markdown
Contributor

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link
Copy Markdown
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few suggestions to make the rule more selective.

---

* This program and the accompanying materials are dual-licensed under
* either the terms of the Eclipse Public License v2.0 as published by
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* either the terms of the Eclipse Public License v2.0 as published by
* either the terms of the {{Eclipse Public License v2.0}} as published by

*
* or (per the licensee's choosing)
*
* under the terms of the GNU Lesser General Public License version 2.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* under the terms of the GNU Lesser General Public License version 2.1
* under the terms of the {{GNU Lesser General Public License version 2.1}}

* either the terms of the Eclipse Public License v2.0 as published by
* the Eclipse Foundation
*
* or (per the licensee's choosing)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* or (per the licensee's choosing)
* or {{(per the licensee's choosing)}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants