Conversation
ThoSap
changed the title
SecretRef and ClusterReference to one common ResourceRef
…one instance is down
…refactor-secret-ref-and-cluster-reference-to-resource-ref # Conflicts: # operator/src/main/java/it/aboutbits/postgresql/core/ClusterReference.java # operator/src/main/java/it/aboutbits/postgresql/core/SecretRef.java # operator/src/main/java/it/aboutbits/postgresql/core/schema_customizer/HostCustomizer.java # operator/src/main/java/it/aboutbits/postgresql/crd/clusterconnection/ClusterConnectionSpec.java
ThoSap
force-pushed
the
refactor-secret-ref-and-cluster-reference-to-resource-ref
branch
from
9d4b9bd to
d95d806
Compare
ThoSap
force-pushed
the
refactor-secret-ref-and-cluster-reference-to-resource-ref
branch
from
d95d806 to
4f0adcc
Compare
…refactor-secret-ref-and-cluster-reference-to-resource-ref # Conflicts: # operator/src/main/java/it/aboutbits/postgresql/core/ClusterReference.java # operator/src/main/java/it/aboutbits/postgresql/core/SecretRef.java
alexlanz
approved these changes
Feb 26, 2026
Base automatically changed from
validate-k8s-resource-references-against-rfc1123
to
main
February 26, 2026 13:48
…-resource-ref # Conflicts: # operator/src/main/java/it/aboutbits/postgresql/core/ClusterReference.java # operator/src/main/java/it/aboutbits/postgresql/core/SecretRef.java # operator/src/main/java/it/aboutbits/postgresql/crd/clusterconnection/ClusterConnectionSpec.java
ThoSap
deleted the
refactor-secret-ref-and-cluster-reference-to-resource-ref
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classes
SecretRefandClusterReferencedid the same thing, so I decided to refactor them into a singleResourceRef.Follow-up task of PR #37