Skip to content

[DX-884] Addresses docs gap around rate limits#3235

Closed
umair-ably wants to merge 1 commit intomainfrom
DX-884-rate-limits
Closed

[DX-884] Addresses docs gap around rate limits#3235
umair-ably wants to merge 1 commit intomainfrom
DX-884-rate-limits

Conversation

@umair-ably
Copy link
Contributor

Description

Addresses docs gap around rate limits

Cannot be merged until the auth PR is merged as this links out to a page introduced in that PR

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch DX-884-rate-limits

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@umair-ably umair-ably changed the title Addresses docs gap around rate limits [DX-884] Addresses docs gap around rate limits Mar 2, 2026
@umair-ably umair-ably added blocked Something that cannot be landed, even when approved Do not merge When the PR is in progress do not merge labels Mar 2, 2026
@umair-ably umair-ably marked this pull request as ready for review March 2, 2026 13:38
@umair-ably umair-ably requested review from AndyTWF and GregHolmes March 2, 2026 13:39
| **Number of channels per connection**<p>*the maximum number of channels that each connection can be attached to*</p> | 200 | 200 | 200 | 200 |
| **Connection state TTL**<p>*the maximum duration that Ably will preserve the state of a dropped connection for*</p> | 2 mins | 2 mins | 2 mins | 2 mins |

## Per-connection rate limiting with JWT <a id="per-connection-rate-limiting"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels odd to put here - limits are about how much your package allows you to do on Ably. Per-connection rate limiting is an authentication/user control concept, should we be conflating the two?

@umair-ably
Copy link
Contributor Author

Closing this PR — #3085 already covers per-connection rate limits on the JWT auth page, so this additional section on the limits page is not needed.

@umair-ably umair-ably closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Something that cannot be landed, even when approved Do not merge When the PR is in progress do not merge

Development

Successfully merging this pull request may close these issues.

2 participants