[DX-882] Improves idempotent publishing guidance#3233
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c799c7d to
e285545
Compare
src/pages/docs/pub-sub/advanced.mdx
Outdated
| ``` | ||
| </Code> | ||
|
|
||
| <Aside data-type='note'> |
There was a problem hiding this comment.
This feels like a weird comment to have here, someone reading this page probably isn't looking at Chat. If we want to talk about idempotency in Chat, should that not be happening on a Chat page? (Also Chat doesn't yet support REST idempotency)
|
|
||
| // Good: Derive from content (deterministic) | ||
| const messageId = `order-${orderId}-confirmed`; | ||
| await channel.publish({ id: messageId, data: payload }); |
There was a problem hiding this comment.
This example won't work if you're batch publishing (publish with array containing >1 message) as there's a special ID format for this
6503841 to
092bda4
Compare
Description
Improves idempotent publishing guidance as per llm-eval docs audit
Checklist