Skip to content

[DX-882] Improves idempotent publishing guidance#3233

Merged
umair-ably merged 2 commits intomainfrom
DX-882-indempotent
Mar 3, 2026
Merged

[DX-882] Improves idempotent publishing guidance#3233
umair-ably merged 2 commits intomainfrom
DX-882-indempotent

Conversation

@umair-ably
Copy link
Contributor

Description

Improves idempotent publishing guidance as per llm-eval docs audit

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch DX-882-indempotent

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@umair-ably umair-ably changed the title Improves idempotent publishing guidance [DX-882] Improves idempotent publishing guidance Mar 2, 2026
@umair-ably umair-ably force-pushed the DX-882-indempotent branch from c799c7d to e285545 Compare March 2, 2026 13:35
@umair-ably umair-ably requested review from AndyTWF and GregHolmes March 2, 2026 13:35
@umair-ably umair-ably marked this pull request as ready for review March 2, 2026 13:35
```
</Code>

<Aside data-type='note'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a weird comment to have here, someone reading this page probably isn't looking at Chat. If we want to talk about idempotency in Chat, should that not be happening on a Chat page? (Also Chat doesn't yet support REST idempotency)


// Good: Derive from content (deterministic)
const messageId = `order-${orderId}-confirmed`;
await channel.publish({ id: messageId, data: payload });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example won't work if you're batch publishing (publish with array containing >1 message) as there's a special ID format for this

@umair-ably umair-ably requested a review from AndyTWF March 3, 2026 12:20
@umair-ably umair-ably force-pushed the DX-882-indempotent branch from 6503841 to 092bda4 Compare March 3, 2026 21:23
@umair-ably umair-ably enabled auto-merge (squash) March 3, 2026 21:23
@umair-ably umair-ably merged commit 7a032ae into main Mar 3, 2026
6 of 7 checks passed
@umair-ably umair-ably deleted the DX-882-indempotent branch March 3, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants