chore: update Android API levels in workflow matrix#1193
Merged
Conversation
WalkthroughGitHub Actions emulator workflow updated: Android API matrix changed to [21, 24, 29, 35]; Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant Matrix as Matrix (api.level)
participant Gradle as gradle-setup@v5
participant AVDInfo as Get AVD info script
participant ArchEval as get-avd-arch step
participant Runner as android-emulator-runner
GH->>Matrix: select API level (21,24,29,35)
GH->>Gradle: setup Gradle (timeout-minutes: 5)
GH->>AVDInfo: request AVD details for api.level
AVDInfo-->>GH: return device name/info
GH->>ArchEval: evaluate api.level -> export arch (x86/x86_64)
ArchEval-->>GH: export ARCH
GH->>Runner: start emulator with arch and target: default
Runner-->>GH: emulator ready / tests run
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
temporarily deployed
to
staging/pull/1193/features
github-actions
bot
temporarily deployed
to
staging/pull/1193/javadoc
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/emulate.yml (1)
42-42: 🛠️ Refactor suggestion | 🟠 MajorRemove the now-dead API-19 conditional from the
scriptstep.With API 19 removed from the matrix,
matrix.android-api-level == 19is alwaysfalse. The expression${{ matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }}permanently evaluates to'', leaving a no-op placeholder in everygradlewinvocation.♻️ Proposed fix
- script: ./gradlew :android:connectedAndroidTest ${{ matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }} || (adb logcat -d System.out:I && exit 1) + script: ./gradlew :android:connectedAndroidTest || (adb logcat -d System.out:I && exit 1)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/emulate.yml at line 42, The script line currently embeds a dead conditional `${{ matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }}` that always evaluates to an empty string; edit the `script` step so the `./gradlew :android:connectedAndroidTest` invocation no longer includes that conditional placeholder (remove the `${{ ... }}` segment) and keep the existing `|| (adb logcat -d System.out:I && exit 1)` fallback intact so the command simply runs `./gradlew :android:connectedAndroidTest` with the same error-handling behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/emulate.yml:
- Line 42: The script line currently embeds a dead conditional `${{
matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }}` that always
evaluates to an empty string; edit the `script` step so the `./gradlew
:android:connectedAndroidTest` invocation no longer includes that conditional
placeholder (remove the `${{ ... }}` segment) and keep the existing `|| (adb
logcat -d System.out:I && exit 1)` fallback intact so the command simply runs
`./gradlew :android:connectedAndroidTest` with the same error-handling behavior.
drop 19, according to Android studio there is 0% of android 19 users
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/emulate.yml:
- Around line 52-55: The conditional referencing matrix.android-api-level == 19
&& '-PhttpURLConnection' is dead code since API 19 was removed; update the
script invocation (the line starting with script: ./gradlew
:android:connectedAndroidTest ...) to remove the conditional and the
'-PhttpURLConnection' branch so it simply runs the connectedAndroidTest command
and preserves the existing failure behavior (e.g., ./gradlew
:android:connectedAndroidTest || (adb logcat -d System.out:I && exit 1)).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/emulate.yml
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/emulate.yml (1)
15-15:⚠️ Potential issue | 🟡 MinorRemove unreachable API 19 test flag branch.
Since API 19 is no longer in the matrix (Line [15]), the conditional in Line [49] is dead code and can be simplified.
🧹 Suggested cleanup
- script: ./gradlew :android:connectedAndroidTest ${{ matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }} || (adb logcat -d System.out:I && exit 1) + script: ./gradlew :android:connectedAndroidTest || (adb logcat -d System.out:I && exit 1)Also applies to: 49-49
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/emulate.yml at line 15, The matrix no longer includes API 19 (the android-api-level entry now lists 21, 24, 29, 35), so remove the dead conditional branch that checks for API level 19 (the conditional handling referenced at Line 49) and any specialized steps or flags tied exclusively to "19"; update any related conditionals or job-steps to rely only on the remaining android-api-level values so the workflow is simplified and no longer contains unreachable branches.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/emulate.yml:
- Line 15: The matrix no longer includes API 19 (the android-api-level entry now
lists 21, 24, 29, 35), so remove the dead conditional branch that checks for API
level 19 (the conditional handling referenced at Line 49) and any specialized
steps or flags tied exclusively to "19"; update any related conditionals or
job-steps to rely only on the remaining android-api-level values so the workflow
is simplified and no longer contains unreachable branches.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/emulate.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drop 19, according to Android studio there is 0% of android 19 users
we'll drop android 19 officially in the next minor release and bump minSdk version
Summary by CodeRabbit