Skip to content

fix: Use case-insensitive matching for A2A headers in gRPC transport #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Mar 11, 2026
Merged

fix: Use case-insensitive matching for A2A headers in gRPC transport #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions client/transport/grpc/src/main/java/io/a2a/client/transport/grpc/GrpcTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,16 +390,17 @@ private Metadata createGrpcMetadata(@Nullable ClientCallContext context, @Nullab
Metadata metadata = new Metadata();

if (context != null && context.getHeaders() != null) {
// Set a2a-version header if present
String versionHeader = context.getHeaders().get(A2AHeaders.A2A_VERSION.toLowerCase());
if (versionHeader != null) {
metadata.put(VERSION_KEY, versionHeader);
}

// Set a2a-extensions header if present
String extensionsHeader = context.getHeaders().get(A2AHeaders.A2A_EXTENSIONS.toLowerCase());
if (extensionsHeader != null) {
metadata.put(EXTENSIONS_KEY, extensionsHeader);
// Set a2a-version and a2a-extensions headers if present, ignoring case
for (Map.Entry<String, String> header : context.getHeaders().entrySet()) {
if (A2AHeaders.A2A_VERSION.equalsIgnoreCase(header.getKey())) {
if (header.getValue() != null) {
metadata.put(VERSION_KEY, header.getValue());
}
} else if (A2AHeaders.A2A_EXTENSIONS.equalsIgnoreCase(header.getKey())) {
if (header.getValue() != null) {
metadata.put(EXTENSIONS_KEY, header.getValue());
}
}
}
Comment on lines +394 to 404
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability and to leverage modern Java features, you could use a stream to process the headers. This separates the filtering of non-null values from the main logic of identifying and adding the relevant headers to the metadata.

            context.getHeaders().entrySet().stream()
                    .filter(header -> header.getValue() != null)
                    .forEach(header -> {
                        if (A2AHeaders.A2A_VERSION.equalsIgnoreCase(header.getKey())) {
                            metadata.put(VERSION_KEY, header.getValue());
                        } else if (A2AHeaders.A2A_EXTENSIONS.equalsIgnoreCase(header.getKey())) {
                            metadata.put(EXTENSIONS_KEY, header.getValue());
                        }
                    });


// Add other headers as needed in the future
Expand Down
Loading