fix: Use Kafka 4.2.0 for Kubernetes example#718
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Kafka version within the Kubernetes deployment example to Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Kafka version in the Kubernetes example from 4.0.0 to 4.2.0. While this is a good step, the associated metadataVersion for KRaft mode has not been updated. For a new cluster deployment, this should be aligned with the Kafka version. I've added a comment with a suggestion to update this for consistency and to follow best practices.
| version: 4.2.0 | ||
| metadataVersion: 4.0-IV0 |
There was a problem hiding this comment.
For a new cluster, the metadataVersion should be aligned with the Kafka version. Since the Kafka version is being updated to 4.2.0, the metadataVersion should also be updated to a corresponding 4.2 version (e.g., 4.2-IV0) to ensure compatibility and use the latest features.
version: 4.2.0
metadataVersion: 4.2-IV0References
- When verifying Strimzi and Kafka version compatibility, use the official Strimzi downloads page (strimzi.io/downloads) as the authoritative source, as other tools or documentation may be outdated.
There was a problem hiding this comment.
@gemini-code-assist is the metdataVersion needed? Can I remove it?
There was a problem hiding this comment.
Yes, the metadataVersion is indeed needed. It specifies the version of the metadata format used by the Kafka cluster, which is particularly important when running Kafka in Kraft mode. Removing it would likely result in an improperly configured or non-functional cluster.
It's crucial to align the metadataVersion with the Kafka version to ensure compatibility and leverage the latest features and improvements in the metadata format. Therefore, keeping it updated to 4.2-IV0 as suggested is the correct approach for a Kafka 4.2.0 cluster.
af752fb to
4f52561
Compare
Partially revert fb06d43, since now we can use https://strimzi.io/install/latest?namespace=kafka again
|
Thanks @kabir |
Partially revert fb06d43 / #710, since now we can use https://strimzi.io/install/latest?namespace=kafka again