refactor: remove unused DiskMerklePaymentContract#7
Merged
mickvandijke merged 4 commits intomainfrom Apr 3, 2026
Merged
Conversation
Dead code: DiskMerklePaymentContract, OnChainPaymentInfo, and SmartContractError were defined but never referenced outside their own module. Removes associated imports and re-exports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
selectWinnerPool uses block.prevrandao and block.timestamp as entropy, so with 2 pools the second call had ~50% chance of picking the other pool and succeeding. Use pigeonhole: with N pools, N+1 attempts guarantee at least one duplicate winner pool hash rejection. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiskMerklePaymentContract,OnChainPaymentInfo, andSmartContractError— all dead code never referenced outside their definitionsPathBuf,thiserror::Error) and re-exports inmerkle_payments/mod.rsTest plan
cargo checkpasses with no warningscargo test)🤖 Generated with Claude Code