fix: payment hardening -- pricing, panics, external signer#5
Open
fix: payment hardening -- pricing, panics, external signer#5
Conversation
- Make pay_for_merkle_tree_calldata() public in the unified PaymentVault handler - Add pay_for_merkle_tree_calldata() to external_signer.rs with MerklePaymentCalldataReturn type for external wallet signing - Uses the unified PaymentVault API (post-V2 refactor)
grumbach
force-pushed
the
fix/payment-upload-hardening
branch
from
c9de1f6 to
eff43ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expect()panics with properResultpropagation inPoolCommitment::to_packed()andget_payment_packed_commitments()calculate_price()toquoting_metrics.rsso client and node share the same deterministic pricing formulapay_for_merkle_tree_calldata())Dependency note
ant-node and ant-client depend on evmlib 0.5.0 from crates.io. This PR needs a new evmlib release before the other two PRs can use it.
Related PRs
Test plan
cfdpasses