Skip to content

switcher: render in stacking order #2935

Merged
ammen99 merged 3 commits intomasterfrom
2907
Apr 13, 2026
Merged

switcher: render in stacking order #2935
ammen99 merged 3 commits intomasterfrom
2907

Conversation

@ammen99
Copy link
Copy Markdown
Member

@ammen99 ammen99 commented Dec 26, 2025

Fixes #2907

@marcusbritanicus @CCobaltDev does this fix the issue as I think it should?

@CCobaltDev
Copy link
Copy Markdown

testing now

@CCobaltDev
Copy link
Copy Markdown

CCobaltDev commented Dec 27, 2025

It fixes the rendering problem (i think?) but makes switching feel really weird

i'd expect it to switch by last-switched-to/by-focus

@ammen99
Copy link
Copy Markdown
Member Author

ammen99 commented Dec 27, 2025

It fixes the rendering problem (i think?) but makes switching feel really weird

i'd expect it to switch by last-switched-to/by-focus

This PR only changes the rendering order but I think I see the issue is more general than I thought. The order of views during the animation is last-focused, but the end state is stacking, so a proper solution would require some special animations to transition between the two. Thanks for testing so far...

@ammen99 ammen99 marked this pull request as draft December 27, 2025 06:05
@CCobaltDev
Copy link
Copy Markdown

Any updates?

@ammen99
Copy link
Copy Markdown
Member Author

ammen99 commented Apr 10, 2026

@CCobaltDev I had some time today and looked again, let me know what you think about the newest version of the code. It is not perfect if you set it to a very slow animation (at 3-4 seconds length you can see artifacts here and there) but I think it should be relatively smooth for normal animation durations (<1s).

@CCobaltDev
Copy link
Copy Markdown

CCobaltDev commented Apr 11, 2026

I like the switcher transparency
There are some window shaking/jitter artifacts with 2 windows

But doing the switch still has some odd behavior - not sure how to describe it so here's my exact case

I have 3 windows open: Firefox, Vesktop, Alacritty
When I focus Firefox and alt+tab, it shows Vesktop, Firefox, Alacritty - Firefox should be last, right? This also leads to where pressing alt+tab twice with 3 windows open has 0 net effect after the animation - same window focused as before the switcher activation
@ammen99

@ammen99
Copy link
Copy Markdown
Member Author

ammen99 commented Apr 11, 2026

@CCobaltDev I pushed some further changes which I think should improve the cases you mentioned, let me know what you think :)

@ammen99 ammen99 marked this pull request as ready for review April 11, 2026 18:46
@CCobaltDev
Copy link
Copy Markdown

Seems to be working great!

@ammen99 ammen99 merged commit f583fb4 into master Apr 13, 2026
8 checks passed
@ammen99 ammen99 deleted the 2907 branch April 13, 2026 07:38
@CCobaltDev
Copy link
Copy Markdown

Thank you so much!

@ammen99
Copy link
Copy Markdown
Member Author

ammen99 commented Apr 13, 2026

Thank you so much!

Thanks for testing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[switcher] Incorrect background window switching

2 participants