Conversation
added 7 commits
January 6, 2026 15:57
mzieg
approved these changes
Apr 2, 2026
Member
mzieg
left a comment
mzieg
left a comment
There was a problem hiding this comment.
I love all the new hexdumps :-)
|
|
||
|
|
||
| // endpoint 0 reader to flush when needed | ||
| UsbEndpointReader spectralReader0; |
Member
There was a problem hiding this comment.
I take it this is not actually used?
Contributor
Author
There was a problem hiding this comment.
It is not. I gotta be honest I have no idea why I thought this might be needed
| set | ||
| { | ||
| byte[] temp = new byte[1]; | ||
| sendCmdReturn(Opcodes.SET_LASER_POWER_ATTENUATOR, (byte)value, buf: temp); |
Member
There was a problem hiding this comment.
I'm not asking you to check for the contents of 'temp' at this point, but for my own traceability:
0 = SUCCESS, 4 = I2C_READ_WR_ERROR, 7 = SETPOINT_RD_BACK_MISMATCH_FLR, 8 = OTP_FUSES_IN_BAD_STATE, 9 = SETPOINT_LOCKED, 10 = UNKNOWN_OTP_FUSE_STATE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.