Skip to content

style(Component Selection): Group by function#2302

Open
hirokiterashima wants to merge 3 commits intodevelopfrom
organize-component-selection-screen
Open

style(Component Selection): Group by function#2302
hirokiterashima wants to merge 3 commits intodevelopfrom
organize-component-selection-screen

Conversation

@hirokiterashima
Copy link
Copy Markdown
Member

Screenshot 2026-04-12 at 7 25 39 PM

Notes

  • Please style as you see fit!
  • There is a lot of code overlap in the two places where we show this component groupings, but I also saw that they had some differences in styles, so I didn't extract a new component. Feel free to extract to a new component if you can and reduce duplication.

Changes

  • In AddYourOwnNode (creating a new blank step) and ChooseNewComponent (adding a component to an existing step) views, organize the components in groups based on function, as seen in the screenshot above.

Test

  • Test the two views and make sure they work as before
    • AddYourOwnNode (creating a new blank step)
    • ChooseNewComponent (adding a component to an existing step)
  • The component select dropdown in the component info dialog works as before. Code that this feature uses was slightly updated in this PR.

@hirokiterashima hirokiterashima self-assigned this Apr 13, 2026
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Apr 13, 2026
@qltysh
Copy link
Copy Markdown

qltysh bot commented Apr 13, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (7)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
src/assets/wise5/components/dialogGuidance/DialogGuidanceInfo.ts100.0%
New file Coverage rating: A
src/assets/wise5/components/html/HtmlInfo.ts100.0%
New file Coverage rating: A
src/assets/wise5/components/summary/SummaryInfo.ts100.0%
New file Coverage rating: A
src/assets/wise5/components/showMyWork/ShowMyWorkInfo.ts100.0%
New file Coverage rating: F
src/assets/wise5/services/componentTypeService.ts12.5%16-65
New file Coverage rating: A
src/assets/wise5/components/match/MatchInfo.ts100.0%
New file Coverage rating: A
src/assets/wise5/components/embedded/EmbeddedInfo.ts100.0%
Total50.0%
🤖 Increase coverage with AI coding...

In the `organize-component-selection-screen` branch, add test coverage for this new code:

- `src/assets/wise5/services/componentTypeService.ts` -- Line 16-65

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review April 13, 2026 02:45
@hirokiterashima hirokiterashima requested a review from breity April 13, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant