Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the event loop management in the server launch process by replacing the deprecated get_event_loop() with new_event_loop(). This change addresses Python 3.10+ deprecation warnings when no event loop is currently running.
- Replaced
get_event_loop()withnew_event_loop()andset_event_loop() - Added proper resource cleanup with try/finally block to ensure the created loop is closed
- Updated imports to reflect the new asyncio functions being used
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
…oop (#493) * Initial plan * Update tests to mock new_event_loop instead of get_event_loop Co-authored-by: kjy5 <82800265+kjy5@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Kenneth Yang <82800265+kjy5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Notes