Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several important updates focused on modernizing the codebase, improving compatibility, and streamlining the documentation build and deployment process. The most significant changes include upgrading the project to Python 3.12, adopting newer Python type hint syntax, refactoring the documentation CI workflows, and making minor code and typing improvements across the codebase.
CI/CD and Documentation Workflow Updates:
.github/workflows/docs.ymlfile, replacing the previous separatedocs_build.ymlanddocs_deploy.ymlworkflows. The new workflow uses standard GitHub-hosted runners, builds documentation withmkdocs, and deploys to GitHub Pages, simplifying the CI process and removing coverage upload steps from the docs workflow. [1] [2] [3]ubuntu-latestrunners instead of self-hosted runners, improving portability and maintainability.Python Version and Typing Modernization:
.python-version, enabling the use of newer language features and type hint syntax.list[str]instead ofList[str],| Noneinstead ofOptional), and removed now-unnecessary imports fromtyping. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Code Quality and Minor Improvements:
QueryInterface.save.# type: ignorecomments in several places incycquery/omop.pyto suppress mypy typing errors for complex assignments. [1] [2] [3] [4] [5]cycquery/mimiciv.py. [1] [2] [3]--unsafetocheck-yaml, removed unusednbqa-blackhook. [1] [2]Database Reflection and Connection Handling:
_setup_table_methodsto use a context-managed connection, improving reliability and compatibility with SQLAlchemy 2.x.