You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@circler3 Thank you for your contribution. The change is generally safe to merge, but I will need some time to give it a test and review it locally. If everything is alright, will merge it.
One thing I noticed is that the only frame processing method that is async is OnStreamFrameAsync and we might want to update the other ones. This might pollute the QuicConnection class, but I think it's okay in the general case.
The library has very basic old-school coding style.
It is a great advantage.
Please, avoid async(s) at all costs.
Also it looks 'fresh and fashion' actually it has a lot of issues
including performance issues and exception handling.
Nice and clean API we see in this implementation is a great treasure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add async methods and examples for those who want to use it in async scenarios.