fix: recover template switching bug fix from PR #1108 (GH#1154)

[superdav42]

Summary

Recovered the valuable code fix from closed-unmerged PR #1108.

The bug was in the Checkout_Form::convert_steps_to_v2 method where array_flip was being used incorrectly on the template list, causing the template switching element to not work properly when templates were configured.

Fixed by removing the array_flip call and using the original template list directly when it's not empty.

Changes

• inc/models/class-checkout-form.php: Removed incorrect array_flip call and simplified the template list logic.

Verification

• Ran vendor/bin/phpunit --filter Template_Switching_Element_Test → OK (7 tests, 25 assertions)
• Ran vendor/bin/phpunit --filter test_is_customer_allowed → OK (6 tests, 6 assertions)

Links

• Issue: consolidated: recover closed-unmerged PR #1108 - template-switching permission notices and switch_template AJAX #1154
• Source PR: fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108

---

[coderabbitai]

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 3 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 182b6456-05fe-49aa-b9ac-88bffe280d9a

📥 Commits

Reviewing files that changed from the base of the PR and between f9480f5 and 8ba3693.

📒 Files selected for processing (1)

• inc/models/class-checkout-form.php

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/auto-20260507-124959-gh1154

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

• Build: ultimate-multisite
• ⬇️ Download from GitHub Actions
• ⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

[github-actions]

Performance Test Results

Performance test results for ccb8e37 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run	DB Queries	Memory	Before Template	Template	WP Total	LCP	TTFB	LCP - TTFB
0	40	37.74 MB	816.00 ms	154.50 ms	1070.50 ms (+47.00 ms / +4% )	2018.00 ms	1925.05 ms (+48.70 ms / +3% )	90.75 ms (+5.00 ms / +6% )
1	56	49.12 MB	974.00 ms (+22.00 ms / +2% )	146.00 ms (+4.00 ms / +3% )	1121.50 ms (+28.00 ms / +2% )	2146.00 ms	2065.40 ms	80.15 ms