Skip to content

Fix bug in _xyz_to_lonlat_rad#1437

Open
rajeeja wants to merge 5 commits intomainfrom
rajeeja/fix__xyz_to_lonlat_rad
Open

Fix bug in _xyz_to_lonlat_rad#1437
rajeeja wants to merge 5 commits intomainfrom
rajeeja/fix__xyz_to_lonlat_rad

Conversation

@rajeeja
Copy link
Contributor

@rajeeja rajeeja commented Jan 7, 2026

Fix #1438 _xyz_to_lonlat_rad normalization to avoid NumPy 2.x aliasing, restoring correct lon/lat in Exodus round‑trip (test failed: test/grid/grid/test_io.py::test_grid_ugrid_exodus_roundtrip) on Python 3.14.

@rajeeja rajeeja requested a review from erogluorhan January 7, 2026 13:37
@rajeeja rajeeja self-assigned this Jan 7, 2026
@erogluorhan
Copy link
Member

This looks good to me, but can you create an issue and describe the problem and how it occurred in the tests?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rajeeja rajeeja force-pushed the rajeeja/fix__xyz_to_lonlat_rad branch from fa64db1 to 49ae14b Compare March 24, 2026 16:17
@rajeeja
Copy link
Contributor Author

rajeeja commented Mar 24, 2026

This looks good to me, but can you create an issue and describe the problem and how it occurred in the tests?

thanks, done, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix test_io AssertionError

2 participants