Skip to content

feat(turndown-plugin-gfm): adopt MD060 compact style for table cells#8840

Merged
eliandoran merged 1 commit intoTriliumNext:mainfrom
yzx9:fix-markdown-table-padding
Feb 26, 2026
Merged

feat(turndown-plugin-gfm): adopt MD060 compact style for table cells#8840
eliandoran merged 1 commit intoTriliumNext:mainfrom
yzx9:fix-markdown-table-padding

Conversation

@yzx9
Copy link
Contributor

@yzx9 yzx9 commented Feb 26, 2026

Style compact avoids extra padding with a single space around cell content:

| Character | Meaning |
| --- | --- |
| Y | Yes |
| N | No |

Closes #8795

Style compact avoids extra padding with a single space around cell
content:

| Character | Meaning |
| --- | --- |
| Y | Yes |
| N | No |

Closes TriliumNext#8795
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 26, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yzx9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the table rendering within the turndown-plugin-gfm package to adhere to the MD060 compact style. This change standardizes the spacing within Markdown table cells, particularly for empty cells, by reducing excessive padding. The primary goal is to improve the generated Markdown's readability and consistency with common linting practices.

Highlights

  • Adopted MD060 Compact Style for Tables: The table generation logic in turndown-plugin-gfm has been updated to follow the MD060 compact style, which reduces extra padding around table cell content, especially for empty cells.
  • Reduced Cell Padding: Empty table cells now use two spaces between pipes (e.g., | |) instead of five spaces (e.g., | |), aligning with the compact style.
  • Updated Test Expectations: Relevant test files have been modified to reflect the new compact table cell formatting, ensuring consistency with the implemented style.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • apps/server/src/services/export/markdown.spec.ts
    • Updated expected Markdown output for tables to reflect the new compact cell styling.
  • packages/turndown-plugin-gfm/src/lib/tables.js
    • Modified the emptyHeader generation to use two spaces for empty cells in the header divider.
    • Added a comment explaining the MD060 compact style for table cells.
    • Removed the while (filteredContent.length < 3) loop that added extra spaces to content.
    • Adjusted handleColSpan to use a single emptyChar for colspan padding instead of emptyChar.repeat(3).
  • packages/turndown-plugin-gfm/test/index.html
    • Updated expected Markdown table outputs in various test cases to match the new compact cell formatting.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully implements a compact style for Markdown tables generated by the turndown-plugin-gfm package, adhering to the MD060 style guide rule. The changes correctly adjust padding for table cells, especially for empty cells and headers, by modifying the cell rendering logic. The associated test files have been updated to validate the new compact output. The implementation is focused and directly addresses the feature request.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2026
@eliandoran eliandoran merged commit 0334166 into TriliumNext:main Feb 26, 2026
9 checks passed
@eliandoran eliandoran added this to the v0.102.0 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown export: short table cells padded to 3 chars causing double spaces (MD060)

2 participants