fix(desktop+server): use exec in launcher scripts

[cbarcenas]

To prevent the parent shell process from lingering

[gemini-code-assist]

Summary of Changes

Hello @cbarcenas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the execution of Trilium desktop and server applications by modifying their respective launcher scripts. By integrating the exec command, the changes ensure a cleaner process lifecycle, directly replacing the shell process with the application's main process and thereby eliminating redundant parent shell processes.

Highlights

• Launcher Script Optimization: The exec command has been prepended to the main executable calls in various desktop and server launcher scripts. This ensures that the shell process is replaced by the executed program, preventing the parent shell from lingering unnecessarily.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• apps/desktop/electron-forge/trilium-no-cert-check.sh
  • Added 'exec' command before calling the 'trilium' executable.
• apps/desktop/electron-forge/trilium-portable.sh
  • Added 'exec' command before calling the 'trilium' executable.
• apps/desktop/electron-forge/trilium-safe-mode.sh
  • Added 'exec' command before calling the 'trilium' executable with the '--disable-gpu' flag.
• apps/server/scripts/build-server.sh
  • Modified the printf command to include 'exec' when creating the trilium.sh script, ensuring the node process replaces the shell.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly introduces the exec command in several launcher scripts to prevent parent shell processes from lingering. This is a good optimization. My review includes suggestions to further improve these scripts by ensuring they forward any command-line arguments they receive to the underlying executable. This will make the wrapper scripts more robust and behave as users would typically expect.