Skip to content

fix(common): drop default values from Device and Component constructors #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ottobolyos wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

fix(common): drop default values from Device and Component constructors #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ad0c081
docs(testing): seed issue-136-137 writeup skeleton
ottobolyos Apr 25, 2026
c2d8ea0
docs(testing): scope device and component ctor defaults defects
ottobolyos Apr 25, 2026
463087e
test(common-tests): add red tests for device and component ctor defaults
ottobolyos Apr 25, 2026
268f341
docs(testing): document red-test matrix for ctor defaults
ottobolyos Apr 25, 2026
1fe8c98
fix(common): drop default values from device and component constructors
ottobolyos Apr 25, 2026
9b51357
fix(sysml-import): drop name back-fill from component template
ottobolyos Apr 25, 2026
8f2cf2d
docs(testing): document library fix and breaking change
ottobolyos Apr 25, 2026
16f673f
test(common-tests): pin device and component ctor defaults regression
ottobolyos Apr 25, 2026
e0b9db1
docs(testing): document regression pins for ctor defaults
ottobolyos Apr 25, 2026
72fbd39
test(xml-tests): pin wire shape after device ctor defaults removal
ottobolyos Apr 25, 2026
a3bda65
docs(testing): document e2e wire-shape validation
ottobolyos Apr 25, 2026
b51327b
docs(testing): author campaign summary for ctor defaults removal
ottobolyos Apr 25, 2026
5227f71
test(common): exempt out-of-scope components from Name back-fill guard
ottobolyos Apr 27, 2026
156372c
chore(docs): remove internal planning leak from committed tree
ottobolyos Apr 27, 2026
4ec4540
test(common): pin shared NameBackfillRemovalOutOfScope helper
ottobolyos Apr 27, 2026
b430c09
test(common): extract shared NameBackfillRemovalOutOfScope helper
ottobolyos Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions build/MTConnect.NET-SysML-Import/CSharp/Templates/Devices.ComponentType.scriban
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ namespace MTConnect.Devices.Components
{{ if (minimum_version_enum) }}public override System.Version MinimumVersion => {{minimum_version_enum}};{{ end }}


public {{name}}()
{
public {{name}}()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ActuatorComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ActuatorComponent : Component
public ActuatorComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AdapterComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class AdapterComponent : Component
public AdapterComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AdaptersComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class AdaptersComponent : Component, IOrganizerComponent
public AdaptersComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AirHandlerComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class AirHandlerComponent : Component
public AirHandlerComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AmplifierComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class AmplifierComponent : Component
public AmplifierComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AutomaticToolChangerComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class AutomaticToolChangerComponent : Component
public AutomaticToolChangerComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AuxiliariesComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class AuxiliariesComponent : Component, IOrganizerComponent
public AuxiliariesComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AuxiliaryComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public abstract class AuxiliaryComponent : Component
public AuxiliaryComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AxesComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class AxesComponent : Component, IOrganizerComponent
public AxesComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/AxisComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public abstract class AxisComponent : Component
public AxisComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/BallscrewComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class BallscrewComponent : Component
public BallscrewComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/BarFeederComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class BarFeederComponent : Component
public BarFeederComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/BeltComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class BeltComponent : Component
public BeltComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/BrakeComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class BrakeComponent : Component
public BrakeComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ChainComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ChainComponent : Component
public ChainComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ChopperComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ChopperComponent : Component
public ChopperComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ChuckComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ChuckComponent : Component
public ChuckComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ChuteComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ChuteComponent : Component
public ChuteComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/CircuitBreakerComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class CircuitBreakerComponent : Component
public CircuitBreakerComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ClampComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ClampComponent : Component
public ClampComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/CompressorComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class CompressorComponent : Component
public CompressorComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ControllerComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ControllerComponent : Component
public ControllerComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ControllersComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ControllersComponent : Component, IOrganizerComponent
public ControllersComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/CoolantComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class CoolantComponent : Component
public CoolantComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/CoolingComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class CoolingComponent : Component
public CoolingComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/CoolingTowerComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class CoolingTowerComponent : Component
public CoolingTowerComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/DepositionComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class DepositionComponent : Component
public DepositionComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/DielectricComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class DielectricComponent : Component
public DielectricComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/DoorComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class DoorComponent : Component
public DoorComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/DrainComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class DrainComponent : Component
public DrainComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ElectricComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ElectricComponent : Component
public ElectricComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/EnclosureComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class EnclosureComponent : Component
public EnclosureComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/EncoderComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class EncoderComponent : Component
public EncoderComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/EndEffectorComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class EndEffectorComponent : Component
public EndEffectorComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/EnvironmentalComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class EnvironmentalComponent : Component
public EnvironmentalComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ExpiredPotComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ExpiredPotComponent : Component
public ExpiredPotComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ExposureUnitComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ExposureUnitComponent : Component
public ExposureUnitComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/ExtrusionUnitComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class ExtrusionUnitComponent : Component
public ExtrusionUnitComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/FanComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class FanComponent : Component
public FanComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/FeatureOccurrenceComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class FeatureOccurrenceComponent : Component
public FeatureOccurrenceComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/FeederComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class FeederComponent : Component
public FeederComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
1 change: 0 additions & 1 deletion libraries/MTConnect.NET-Common/Devices/Components/FilterComponent.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class FilterComponent : Component
public FilterComponent()
{
Type = TypeId;
Name = NameId;
}
}
}
Loading