feat(script): Extend the functionality of team generic scripts#2510
Draft
Mauller wants to merge 4 commits intoTheSuperHackers:mainfrom
Draft
feat(script): Extend the functionality of team generic scripts#2510Mauller wants to merge 4 commits intoTheSuperHackers:mainfrom
Mauller wants to merge 4 commits intoTheSuperHackers:mainfrom
Conversation
Author
|
seems to be some mismatching that i was not expecting |
256ce49 to
d23f060
Compare
d23f060 to
8917f80
Compare
Author
|
All good, i gated the changes behind a new compilation conditional and refactored the orignal coded a little to make it easier to read when compared to the new code. |
8917f80 to
ee8ee5d
Compare
Author
|
Just a small tweak so the non retail code could be built in VC6 too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1468
This PR fixes and extends the functionality of Team generic scripts.
Team generic scripts are evaluated within their own update function on the team instead of within the script engine. This allows the handling of the "This Team" behaviour to be evalutated properly.
Originally Team generic scripts would ignore many script properties and had limited functionality compared to normal scripts that execute within the script engine. They were also shared between all instances of a team as the scripts existed on the team prototype.
This PR enables the following functionality for Team generic scripts;
The extended functionality is currently hidden behind a conditional to make sure the retail behaviour is currently maintained.
This was done to prevent mismatching when TSH clients play with retail clients, so a mismatch is prevented when a map has properties enabled that would have been ignored by retail.