Skip to content

Improve sorted input validation in binary search #14074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximSmolskiy merged 7 commits into from
Mar 9, 2026
Merged

Improve sorted input validation in binary search #14074

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cf726a
Improve sorted input validation in binary search
YASWANTH1976 Jan 3, 2026
0b3a221
Merge branch 'master' into patch-2
YASWANTH1976 Jan 5, 2026
45ecb09
Merge branch 'master' into patch-2
YASWANTH1976 Jan 7, 2026
d1f6b90
Update binary_search.py
MaximSmolskiy Mar 9, 2026
368eabd
Update binary_search.py
MaximSmolskiy Mar 9, 2026
3746b08
Update binary_search.py
MaximSmolskiy Mar 9, 2026
0a3e26c
Merge branch 'master' into patch-2
MaximSmolskiy Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions searches/binary_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@
python3 binary_search.py
"""

from __future__ import annotations

import bisect
from itertools import pairwise


def bisect_left(
Expand Down Expand Up @@ -198,7 +197,7 @@ def binary_search(sorted_collection: list[int], item: int) -> int:
>>> binary_search([0, 5, 7, 10, 15], 6)
-1
"""
if list(sorted_collection) != sorted(sorted_collection):
if any(a > b for a, b in pairwise(sorted_collection)):
raise ValueError("sorted_collection must be sorted in ascending order")
left = 0
right = len(sorted_collection) - 1
Expand Down