fix: use SDC_FILE_EXTRA for mock-cpu util.tcl sourcing#4093
Open
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
fix: use SDC_FILE_EXTRA for mock-cpu util.tcl sourcing#4093oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
The constraint.sdc used a hardcoded $::env(DESIGN_HOME) path and io.tcl tried two relative paths with file-exists guards. Both are fragile and break in sandboxed build environments. Use SDC_FILE_EXTRA to declare the dependency in config.mk and source $::env(SDC_FILE_EXTRA) for a portable path in both files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Collaborator
Author
|
Also this will be explicitly supported in bazel-orfs to set up the dependency. |
Collaborator
Author
|
@maliberty Aha! microwatt is flaky, didn't change it in this PR. |
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Apr 2, 2026
Use SDC_FILE_EXTRA variable instead of hardcoded paths to source mock-array/util.tcl. This works correctly in both Make and Bazel. Cherry-pick of PR The-OpenROAD-Project#4093. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Apr 2, 2026
Use SDC_FILE_EXTRA variable instead of hardcoded paths to source mock-array/util.tcl. This works correctly in both Make and Bazel. Cherry-pick of PR The-OpenROAD-Project#4093. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constraint.sdc used a hardcoded $::env(DESIGN_HOME) path and io.tcl tried two relative paths with file-exists guards. Both are fragile and break in sandboxed build environments.
Use SDC_FILE_EXTRA to declare the dependency in config.mk and source $::env(SDC_FILE_EXTRA) for a portable path in both files.