fix: add ihp-sg13g2 IO pad libs to i2c-gpio-expander for all corners#4090
Open
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
fix: add ihp-sg13g2 IO pad libs to i2c-gpio-expander for all corners#4090oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
The i2c-gpio-expander design instantiates IO pad cells but the platform config.mk adds the IO pad libraries conditionally (ifneq FOOTPRINT_TCL). Declare these dependencies explicitly so the design works regardless of how the conditional is evaluated. Add ADDITIONAL_SLOW_LIBS, ADDITIONAL_FAST_LIBS, ADDITIONAL_GDS alongside the existing ADDITIONAL_LIBS/LEFS/VERILOG_FILES additions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Apr 2, 2026
Explicitly declare IO pad verilog, LEF, lib (all corners), and GDS files for robustness, rather than relying on platform config.mk conditional logic. Cherry-pick of PR The-OpenROAD-Project#4090. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Apr 2, 2026
Explicitly declare IO pad verilog, LEF, lib (all corners), and GDS files for robustness, rather than relying on platform config.mk conditional logic. Cherry-pick of PR The-OpenROAD-Project#4090. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
Apr 3, 2026
Explicitly declare IO pad verilog, LEF, lib (all corners), and GDS files for robustness, rather than relying on platform config.mk conditional logic. Cherry-pick of PR The-OpenROAD-Project#4090. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The i2c-gpio-expander design instantiates IO pad cells but the platform config.mk adds the IO pad libraries conditionally (ifneq FOOTPRINT_TCL). Declare these dependencies explicitly so the design works regardless of how the conditional is evaluated.
Add ADDITIONAL_SLOW_LIBS, ADDITIONAL_FAST_LIBS, ADDITIONAL_GDS alongside the existing ADDITIONAL_LIBS/LEFS/VERILOG_FILES additions.