-
Notifications
You must be signed in to change notification settings - Fork 470
Use yosys stat -json for metrics extraction #4019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohithsiddi
wants to merge
2
commits into
The-OpenROAD-Project:master
Choose a base branch
from
rohithsiddi:yosys-stat-json-metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−16
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -231,20 +231,50 @@ def extract_metrics( | |
| # Synthesis | ||
| # ========================================================================= | ||
|
|
||
| # The new format (>= 0.57) is: <count> <area> cells | ||
| extractTagFromFile( | ||
| "synth__design__instance__count__stdcell", | ||
| metrics_dict, | ||
| "^\\s+(\\d+)\\s+[-0-9.]+\\s+cells$", | ||
| rptPath + "/synth_stat.txt", | ||
| ) | ||
| synth_stat_file = rptPath + "/synth_stat.json" | ||
| try: | ||
| with open(synth_stat_file) as f: | ||
| content = f.read() | ||
| # yosys may emit log messages (e.g. "Found gzip magic in file...") | ||
| # before the JSON when reading compressed liberty files. Skip them. | ||
|
Comment on lines
+235
to
+239
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the above is implemented we likely will not need this post-processing. |
||
| synth_stat = json.loads(content[content.index("{") :]) | ||
| modules = synth_stat.get("modules", {}) | ||
| # Prefer lookup by design name; yosys may prefix module names with a | ||
| # backslash in JSON output, so try both forms. Fall back to the last | ||
| # module in the output, which yosys emits last for the top-level module. | ||
| top_module = ( | ||
| modules.get(design) | ||
| or modules.get("\\" + design) | ||
| or (list(modules.values())[-1] if modules else None) | ||
| ) | ||
|
|
||
| num_cells = top_module.get("num_cells") if top_module else None | ||
| if num_cells is None: | ||
| print( | ||
| "[WARN] Tag synth__design__instance__count__stdcell not found in {}.".format( | ||
| synth_stat_file | ||
| ), | ||
| "Will use N/A.", | ||
| ) | ||
| metrics_dict["synth__design__instance__count__stdcell"] = "N/A" | ||
| else: | ||
| metrics_dict["synth__design__instance__count__stdcell"] = int(num_cells) | ||
|
|
||
| extractTagFromFile( | ||
| "synth__design__instance__area__stdcell", | ||
| metrics_dict, | ||
| "Chip area for (?:top )?module.*: +(\\S+)", | ||
| rptPath + "/synth_stat.txt", | ||
| ) | ||
| area = top_module.get("area") if top_module else None | ||
| if area is None: | ||
| print( | ||
| "[WARN] Tag synth__design__instance__area__stdcell not found in {}.".format( | ||
| synth_stat_file | ||
| ), | ||
| "Will use N/A.", | ||
| ) | ||
| metrics_dict["synth__design__instance__area__stdcell"] = "N/A" | ||
| else: | ||
| metrics_dict["synth__design__instance__area__stdcell"] = float(area) | ||
| except (IOError, json.JSONDecodeError, ValueError): | ||
| print("[ERROR] Failed to open file:", synth_stat_file) | ||
| metrics_dict["synth__design__instance__count__stdcell"] = "ERR" | ||
| metrics_dict["synth__design__instance__area__stdcell"] = "ERR" | ||
|
|
||
| # Clocks | ||
| # ========================================================================= | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should tee to a log file and use the
-ooption to output a valid JSON:https://yosyshq.readthedocs.io/projects/yosys/en/latest/cmd/index_backends.html#json-write-design-in-json-format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The json backend (
write_json -o) outputs the design netlist rather than synthesis statistics, it doesn't include aggregated cell count or area values that we need for metrics.stat -jsonprovides these but doesn't support-o; its docs recommend usingteefor file output. Our current approach usestee -oto capturestat -jsonand skips any log prefix (e.g. "Found gzip magic") ingenMetrics.pybefore parsing. Would this be acceptable?