Skip to content

Add where op and torch.lt/gt/le/ge/eq/ne#6551

Open
futz12 wants to merge 13 commits intoTencent:masterfrom
futz12:where-op
Open

Add where op and torch.lt/gt/le/ge/eq/ne#6551
futz12 wants to merge 13 commits intoTencent:masterfrom
futz12:where-op

Conversation

@futz12
Copy link
Copy Markdown
Contributor

@futz12 futz12 commented Feb 20, 2026

supoort for

  1. “==”
  2. ”!=”
  3. ”>”
  4. ”<”
  5. ”>=”
  6. ”<=”
  7. where ( x[x > 0] )
  8. masked_fill

@futz12 futz12 mentioned this pull request Mar 4, 2026
19 tasks
@futz12
Copy link
Copy Markdown
Contributor Author

futz12 commented Apr 16, 2026

@nihui try it again please

@nihui
Copy link
Copy Markdown
Member

nihui commented Apr 24, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 237523f78e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/pnnx/src/pass_ncnn/Tensor_masked_fill.cpp Outdated
Comment thread src/layer/where.cpp
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7bac1f052

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/layer/compareop.cpp
Comment thread src/layer/logical.cpp
Comment thread src/layer/where.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants