Skip to content

[bug] 프로필 이미지 업로드 및 조회 오류 수정#169

Merged
geunyong16 merged 3 commits into
mainfrom
bug/152-프로필-사진-등록-오류
May 4, 2026

Hidden character warning

The head ref may contain hidden characters: "bug/152-\ud504\ub85c\ud544-\uc0ac\uc9c4-\ub4f1\ub85d-\uc624\ub958"
Merged

[bug] 프로필 이미지 업로드 및 조회 오류 수정#169
geunyong16 merged 3 commits into
mainfrom
bug/152-프로필-사진-등록-오류

Conversation

@thdud7
Copy link
Copy Markdown
Collaborator

@thdud7 thdud7 commented May 2, 2026

변경 사항

  • 내 프로필 이미지 업로드 API를 추가했습니다.
  • 로컬 저장, 정적 서빙, 응답 URL 해석 로직을 추가해 업로드 후 조회가 가능하도록 수정했습니다.
  • 프로필 이미지 URL 검증 규칙을 서버 경로까지 허용하도록 보완했습니다.

테스트

  • ./gradlew test --tests 'com.example.paycheck.domain.user.service.ProfileImageStorageServiceTest' --tests 'com.example.paycheck.domain.user.service.ProfileImageUrlResolverTest' --tests 'com.example.paycheck.domain.user.service.UserServiceTest' --tests 'com.example.paycheck.domain.user.service.UserServiceSimpleTest'

@thdud7 thdud7 linked an issue May 2, 2026 that may be closed by this pull request
3 tasks
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@geunyong16 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 35 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9854c2e5-5110-4c26-87ac-06a391d44beb

📥 Commits

Reviewing files that changed from the base of the PR and between 130e56a and e9267c5.

📒 Files selected for processing (12)
  • src/main/java/com/example/paycheck/api/user/UserController.java
  • src/main/java/com/example/paycheck/domain/user/dto/UserDto.java
  • src/main/java/com/example/paycheck/domain/user/service/ProfileImageStorageService.java
  • src/main/java/com/example/paycheck/domain/user/service/ProfileImageUrlResolver.java
  • src/main/java/com/example/paycheck/domain/user/service/UserService.java
  • src/main/java/com/example/paycheck/global/config/WebMvcConfig.java
  • src/main/resources/application.properties
  • src/test/java/com/example/paycheck/api/user/UserControllerTest.java
  • src/test/java/com/example/paycheck/domain/user/service/ProfileImageStorageServiceTest.java
  • src/test/java/com/example/paycheck/domain/user/service/ProfileImageUrlResolverTest.java
  • src/test/java/com/example/paycheck/domain/user/service/UserServiceSimpleTest.java
  • src/test/java/com/example/paycheck/domain/user/service/UserServiceTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/152-프로필-사진-등록-오류

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 25 minutes and 35 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

geunyong16 added 2 commits May 3, 2026 23:33
ProfileImageStorageService가 uploadProfileImage(Long, MultipartFile) -> store(MultipartFile)로 리네임되었지만,
UserService의 레거시 uploadProfileImage() 메서드가 삭제되지 않아 사라진 메서드를 호출하면서 컴파일 에러 발생.

변경 사항:
- UserService의 데드 메서드 uploadProfileImage() 제거 (Controller는 이미 updateProfileImage() 호출)
- UserServiceTest의 uploadProfileImage_Success 테스트를 updateProfileImage 흐름 검증으로 교체
- UserControllerTest의 uploadMyProfileImage_success 테스트를 신규 시그니처(updateProfileImage, Response 반환)에 맞게 수정
@geunyong16 geunyong16 merged commit f947835 into main May 4, 2026
2 checks passed
@geunyong16 geunyong16 deleted the bug/152-프로필-사진-등록-오류 branch May 4, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 프로필 사진이 등록되지 않거나 표시되지 않음

2 participants