fix(solid-query): allow both create/use syntax#10260
Conversation
🦋 Changeset detectedLatest commit: e8ecdba The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a changeset and extends Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit e8ecdba
☁️ Nx Cloud last updated this comment at |
size-limit report 📦
|
|
🎉 This PR has been released! Thank you for your contribution! |
Query transitioned from create* to use* here:
createin favor ofuse, and add full docs #8950It helped a lot with solid maintenance by aligning docs / api surface to vue/svelte/react, and ease of migration between frameworks. Unfortunately this is in some cases less solid-idiomatic (useIsFetching, useMutationState, useIsMutating, useIsRestoring - these return accessors), and even worse it ended up being breaking, because the type forwarding wasn't correctly configured, so some libraries had to pin query versions. Type forwarding since fixed here (thanks!), but deprecation warnings remained:
To make things just work, this PR allow both the use* syntax for ease of maintenance and migration from react, and the idiomatic create* syntax for existing users and for the idiomatic preference The PR drops the deprecation warnings so that both will work just fine, and add a few extra exports of create*.
cc @2wheeh
Summary by CodeRabbit