Skip to content

Add formulas for bispectrum in fourier.py#640

Draft
matteobachetti wants to merge 1 commit intomainfrom
add_bispectrum_from_iterable
Draft

Add formulas for bispectrum in fourier.py#640
matteobachetti wants to merge 1 commit intomainfrom
add_bispectrum_from_iterable

Conversation

@matteobachetti
Copy link
Copy Markdown
Member

@matteobachetti matteobachetti commented Feb 21, 2022

Not for the 1.0 release.
I had drafted these functions to work on my time series analysis classes, and Issue #639 was a good excuse to start thinking about using them in Stingray :)


This change is Reviewable

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Feb 21, 2022

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 13:101: E501 line too long (102 > 100 characters)

Comment last updated at 2022-02-24 10:45:49 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2022

Codecov Report

❌ Patch coverage is 12.19512% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.75%. Comparing base (8b4b3e7) to head (9bad0b5).
⚠️ Report is 1598 commits behind head on main.

Files with missing lines Patch % Lines
stingray/fourier.py 3.84% 25 Missing ⚠️
stingray/bispectrum.py 26.66% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   97.21%   96.75%   -0.47%     
==========================================
  Files          41       41              
  Lines        7535     7576      +41     
==========================================
+ Hits         7325     7330       +5     
- Misses        210      246      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matteobachetti matteobachetti force-pushed the add_bispectrum_from_iterable branch from 21e8525 to 9bad0b5 Compare February 24, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants