ci: adopt golangci-lint v2.12.1 and exclude goconst from tests#129
Merged
ChrisJBurns merged 1 commit intomainfrom May 3, 2026
Merged
ci: adopt golangci-lint v2.12.1 and exclude goconst from tests#129ChrisJBurns merged 1 commit intomainfrom
ChrisJBurns merged 1 commit intomainfrom
Conversation
Pin golangci-lint to v2.12.1 in the lint workflow. The action was unpinned and auto-installing the latest binary, which could break main when v2.12.1 shipped with stricter goconst defaults. Exclude goconst from (.+)_test\.go in .golangci.yml. Test fixtures legitimately repeat literals like "Hello, World!" and "test-agent"; forcing constants there adds noise without value, and matches the existing test-file exclusions for lll, gocyclo, errcheck, dupl, gosec, paralleltest. Verified locally with golangci-lint v2.12.1: 0 issues. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JAORMX
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lintto v2.12.1 in.github/workflows/lint.yml. The action was unpinned and auto-installing the latest binary, which could breakmainwhen v2.12.1 shipped with strictergoconstdefaults.goconstfrom(.+)_test\.goin.golangci.yml. Test fixtures legitimately repeat literals like"Hello, World!"and"test-agent"; forcing constants there adds noise without value, and matches the existing test-file exclusions forlll,gocyclo,errcheck,dupl,gosec,paralleltest.No production-code
goconstfindings in this repo, so unlike the yardstick equivalent (StacklokLabs/yardstick#101) no constants needed extracting fromcmd/.Verified locally with
golangci-lint v2.12.1:0 issues.Test plan
Installing golangci-lint binary v2.12.1🤖 Generated with Claude Code